Rust: Add a couple of simple data flow test cases #20439
Conversation
geoffw0
added
no-change-note-required
There was a problem hiding this comment.
Pull Request Overview
This PR adds simple test cases for data flow analysis in Rust, specifically testing assignment patterns including self-assignment scenarios. The changes add test code to verify that data flow tracking correctly handles variable assignments, including cases where self-assignment should preserve data flow but appears to have issues.
- Adds test cases for variable assignment and data flow tracking
- Tests self-assignment scenario that appears to have missing data flow detection
- Updates expected test results to reflect current data flow analysis behavior
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/test/library-tests/dataflow/local/main.rs | Adds assignment test cases including self-assignment that should preserve data flow |
| rust/ql/test/library-tests/dataflow/local/inline-flow.expected | Updates expected test results with new data flow edges and missing flow annotations |
|
|
||
| let mut l = source(8); | ||
| l = l; | ||
| sink(l); // $ MISSING: hasValueFlow=8 |
There was a problem hiding this comment.
Should be fixed by #20443.
There was a problem hiding this comment.
Yep that fixes the issue, if we merge that first I can merge it in and update the .expected here.
There was a problem hiding this comment.
Thanks for addressing this!
|
Merged with |
Add a couple of simple data flow test cases. We don't seem to be getting self-assignment right.
@hvitved any idea what's wrong here?