JS: Model Express json and jsonp methods #20419
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds modeling for Express.js response methods json() and jsonp() to the CodeQL JavaScript library. These methods are commonly used to send JSON responses and set appropriate content-type headers.
- Adds new classes to model
res.json()andres.jsonp()calls as header definitions and response send arguments - Creates test cases to verify the modeling works correctly with Express routes
- Updates expected test results to include the new JSON response handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| javascript/ql/lib/semmle/javascript/frameworks/Express.qll | Adds ResponseJsonCall and ResponseJsonCallArgument classes to model Express json/jsonp methods |
| javascript/ql/test/library-tests/frameworks/Express/src/json.js | New test file with routes using res.json() and res.jsonp() |
| javascript/ql/test/library-tests/frameworks/Express/tests.expected | Updated expected test results to include the new JSON response modeling |
Napalys
previously approved these changes
Sep 16, 2025
Co-authored-by: Copilot <[email protected]>
Napalys
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.