feat(prevent): create endpoint that fetches repositories list #95181

adrianviquez · 2025-07-09T22:28:57Z

This PR creates and endpoint that fetches a list of repositories belonging to a specific owner

Notes

Added path to access endpoint
Added query file with GQL query
Added endpoint logic + its serializer
Added test file for said logic

src/sentry/codecov/endpoints/Repositories/repositories.py

src/sentry/codecov/endpoints/Repositories/serializers.py

src/sentry/codecov/endpoints/Repositories/repositories.py

src/sentry/codecov/endpoints/Repositories/query.py

src/sentry/codecov/endpoints/Repositories/repositories.py

ajay-sentry · 2025-07-10T00:11:22Z

src/sentry/codecov/endpoints/Repositories/repositories.py

+        request=None,
+        responses={
+            200: RepositoriesSerializer,
+            400: RESPONSE_BAD_REQUEST,


If you're up for it, one thing I didn't do with my initial implementation of the serializers with the test results one is to actually throw the exceptions in the serializer if we error out on the owner part of the request.

https://github.com/codecov/umbrella/blob/02de63009831bee26cb65113b35f6ef53ed32a3b/apps/codecov-api/graphql_api/types/repository/repository.graphql#L95 All of this stuff basically would be in the GQL request IIRC.

But for repositories also maybe not, because it returns a set of RepositoryConnections, in which case idk when we'd return 404 or 403 🤔 Something we can maybe talk about later

codecov · 2025-07-10T04:50:29Z

Codecov Report

Attention: Patch coverage is 97.35099% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ntry/codecov/endpoints/Repositories/serializers.py	91.17%	3 Missing ⚠️
...try/codecov/endpoints/Repositories/repositories.py	97.61%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #95181      +/-   ##
==========================================
+ Coverage   87.83%   87.84%   +0.01%     
==========================================
  Files       10478    10487       +9     
  Lines      605897   605479     -418     
  Branches    23668    23586      -82     
==========================================
- Hits       532177   531880     -297     
+ Misses      73356    73239     -117     
+ Partials      364      360       -4

GabeVillalobos · 2025-07-10T18:13:14Z

Is there a tech spec detailing which new API endpoints we're implementing within Sentry? We probably need security to review these and the data we're ferrying to Codecov in the process.

dcramer · 2025-07-10T18:18:32Z

src/sentry/api/urls.py

@@ -3307,6 +3308,11 @@ def create_group_urls(name_prefix: str) -> list[URLPattern | URLResolver]:
        TestResultsAggregatesEndpoint.as_view(),
        name="sentry-api-0-test-results-aggregates",
    ),
+    re_path(


i realize this is beyond the scope of this - but these URLs are not maintainable - they should all be prefixed if we're allowing repo access outside of org-scoped queries

e.g. /gh-repos/ or something similar

@dcramer We actually just moved these over to be org scoped hehe. This one will be rebased and further created endpoints will follow suit

Related slack thread: https://sentry.slack.com/archives/C08HLC09Z8A/p1752079936486329

ajay-sentry · 2025-07-10T18:25:27Z

@GabeVillalobos We're pulling data from Codecov rather than ferrying to Codecov, unless you mean the request parameters for these endpoints?

GabeVillalobos · 2025-07-10T23:03:24Z

@GabeVillalobos We're pulling data from Codecov rather than ferrying to Codecov, unless you mean the request parameters for these endpoints?

@ajay-sentry Yep, I'm mainly interested in request parameters, or request bodies for future PUT/POST requests.

ajay-sentry · 2025-07-11T20:05:27Z

src/sentry/api/urls.py

@@ -1065,6 +1066,11 @@ def create_group_urls(name_prefix: str) -> list[URLPattern | URLResolver]:
        TestResultsAggregatesEndpoint.as_view(),
        name="sentry-api-0-test-results-aggregates",
    ),
+    re_path(
+        r"^owner/(?P<owner>[^/]+)/repositories/$",


man, this made me realize I probably should've named the other routes repositories rather than repository, maybe I can do a follow up on this

ajay-sentry · 2025-07-11T20:06:31Z

src/sentry/codecov/endpoints/Repositories/query.py

+        }
+      }
+      pageInfo {
+          endCursor


Can you also add hasPreviousPage and startCursor?

ajay-sentry · 2025-07-11T20:09:14Z

tests/sentry/codecov/endpoints/test_repositories.py

+        ), f"Response keys {response_keys} don't match serializer fields {serializer_fields}"
+
+    @patch("sentry.codecov.endpoints.Repositories.repositories.CodecovApiClient")
+    def test_get_with_query_parameters(self, mock_codecov_client_class):


This test is just testing for the "term" query parameter right? Not all of them

will add test w/ all the query params

ajay-sentry · 2025-07-11T20:26:21Z

tests/sentry/codecov/endpoints/test_repositories.py

+        assert response.status_code == 200
+
+    @patch("sentry.codecov.endpoints.Repositories.repositories.CodecovApiClient")
+    def test_get_with_last_parameter(self, mock_codecov_client_class):


wonder if we should do a similar thing like we did in test_results where we just had the "no response mock" be a const at the top of the file so we can keep the rest of the test pretty lean

ajay-sentry · 2025-07-11T20:26:48Z

src/sentry/codecov/endpoints/Repositories/repositories.py

+        try:
+            first = int(first_param) if first_param is not None else None
+            last = int(last_param) if last_param is not None else None
+        except ValueError:


can we add some simple tests for these error responses?

ajay-sentry

mostly small stuff, looks good

feat: create endpoint that fetches repositories list

965b8ad

adrianviquez requested review from a team as code owners July 9, 2025 22:28

vercel bot deployed to Preview July 9, 2025 22:29 View deployment

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 9, 2025

adrianviquez commented Jul 9, 2025

View reviewed changes

src/sentry/codecov/endpoints/Repositories/repositories.py Show resolved Hide resolved

adrianviquez commented Jul 9, 2025

View reviewed changes

src/sentry/codecov/endpoints/Repositories/serializers.py Show resolved Hide resolved

adrianviquez commented Jul 9, 2025

View reviewed changes

src/sentry/codecov/endpoints/Repositories/repositories.py Outdated Show resolved Hide resolved

ajay-sentry reviewed Jul 10, 2025

View reviewed changes

src/sentry/codecov/endpoints/Repositories/query.py Show resolved Hide resolved

ajay-sentry reviewed Jul 10, 2025

View reviewed changes

src/sentry/codecov/endpoints/Repositories/repositories.py Outdated Show resolved Hide resolved

ajay-sentry reviewed Jul 10, 2025

View reviewed changes

GabeVillalobos requested a review from a team July 10, 2025 18:13

dcramer reviewed Jul 10, 2025

View reviewed changes

merge

1bb2065

vercel bot deployed to Preview July 10, 2025 22:29 View deployment

feat: add pagination capability for endpoitn

0ef00c4

vercel bot deployed to Preview July 10, 2025 23:50 View deployment

This comment was marked as outdated.

Sign in to view

adjust qgl query to take after, last and before params

20a7b9f

vercel bot deployed to Preview July 11, 2025 17:32 View deployment

This comment was marked as outdated.

Sign in to view

add int validation for first + last

36cebd2

vercel bot deployed to Preview July 11, 2025 17:38 View deployment

This comment was marked as outdated.

Sign in to view

Correct 500 to 400 error

1faba51

vercel bot deployed to Preview July 11, 2025 17:41 View deployment

This comment was marked as outdated.

Sign in to view

address interger and none conditions for first + last

d32e19e

vercel bot deployed to Preview July 11, 2025 18:03 View deployment

typo on Any

d3bf201

vercel bot deployed to Preview July 11, 2025 18:12 View deployment

ajay-sentry reviewed Jul 11, 2025

View reviewed changes

ajay-sentry approved these changes Jul 11, 2025

View reviewed changes

adjusted serialzser to include cursor and end params + adjusted tests

c8dbbd1

vercel bot deployed to Preview July 11, 2025 23:03 View deployment

Uh oh!

feat(prevent): create endpoint that fetches repositories list #95181

Are you sure you want to change the base?

feat(prevent): create endpoint that fetches repositories list #95181

Conversation

adrianviquez commented Jul 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

GabeVillalobos commented Jul 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajay-sentry Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajay-sentry commented Jul 10, 2025

Uh oh!

GabeVillalobos commented Jul 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajay-sentry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jul 10, 2025 •

edited

Loading

ajay-sentry Jul 10, 2025 •

edited

Loading