Skip to content

Factor out do_request in HTTP transport #2662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

sl0thentr0py
Copy link
Member

to support the use case in #2661

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (92cb875) to head (cfdee3a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2662   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files         134      134           
  Lines        5167     5169    +2     
=======================================
+ Hits         5036     5038    +2     
  Misses        131      131           
Components Coverage Δ
sentry-ruby 97.73% <100.00%> (+<0.01%) ⬆️
sentry-rails 96.55% <ø> (ø)
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/transport/http_transport.rb 98.18% <100.00%> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sl0thentr0py sl0thentr0py merged commit 818b6c0 into master Jul 14, 2025
140 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/transport-expose-do-request branch July 14, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants