Skip to content

fix: use full URL as resource URI instead of just host #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jul 10, 2025

The resource URI should be the complete URL to properly identify the resource, not just the host portion. This ensures resources are uniquely identifiable and follows proper URI semantics.

🤖 Generated with Claude Code

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.65%. Comparing base (e742b90) to head (bab39b2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   62.65%   62.65%   -0.01%     
==========================================
  Files          77       77              
  Lines        6880     6879       -1     
  Branches      620      620              
==========================================
- Hits         4311     4310       -1     
  Misses       2569     2569              
Flag Coverage Δ
unittests 62.65% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The resource URI should be the complete URL to properly identify the resource,
not just the host portion. This ensures resources are uniquely identifiable
and follows proper URI semantics.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@dcramer dcramer force-pushed the fix/resource-uri branch from 03adfb2 to bab39b2 Compare July 10, 2025 23:05
@dcramer dcramer merged commit a69d3a6 into main Jul 10, 2025
13 checks passed
@dcramer dcramer deleted the fix/resource-uri branch July 10, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant