feat: add ConfigurationError class for network/connection issues #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new ConfigurationError class to distinguish between user input errors and system configuration issues. This improves error handling by: - Creating ConfigurationError class that extends Error with cause support - Treating DNS resolution failures (ENOTFOUND, EAI_AGAIN) as configuration errors - Treating connection errors (ECONNREFUSED, ETIMEDOUT) as configuration errors - Preventing these configuration errors from being sent to Sentry - Providing clear, user-friendly error messages for configuration issues - Adding proper TypeScript type predicates for all error type guards This ensures that when users provide invalid Sentry hosts or have network configuration issues, they receive helpful error messages without polluting Sentry with expected configuration errors. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 62.65% 62.65%
=======================================
Files 77 77
Lines 6855 6880 +25
Branches 613 620 +7
=======================================
+ Hits 4295 4311 +16
- Misses 2560 2569 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new ConfigurationError class to distinguish between user input errors and system configuration issues. This improves error handling by:
This ensures that when users provide invalid Sentry hosts or have network configuration issues, they receive helpful error messages without polluting Sentry with expected configuration errors.
🤖 Generated with Claude Code