Skip to content

fix: improve 404 error handling to show all relevant parameters #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jul 10, 2025

Instead of trying to guess which resource caused a 404, now we list all path parameters that were used in the API call. This provides clearer error messages that help users identify which parameter might be incorrect.

Example error message:

Resource not found. Please verify these parameters are correct:
  - organizationSlug: 'my-org'
  - issueId: 'PROJ-123'

Changes:

  • Simplified error handling to remove operation tracking
  • Tools now only pass path parameters that could cause 404s
  • Error messages list all relevant parameters for better debugging

Fixes MCP-SERVER-EA1, MCP-SERVER-E9B

🤖 Generated with Claude Code

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 98.50746% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.65%. Comparing base (56aff50) to head (b3ee93c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/mcp-server/src/tools/find-issues.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   62.46%   62.65%   +0.19%     
==========================================
  Files          77       77              
  Lines        6844     6855      +11     
  Branches      613      613              
==========================================
+ Hits         4275     4295      +20     
+ Misses       2569     2560       -9     
Flag Coverage Δ
unittests 62.65% <98.50%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Instead of trying to guess which resource caused a 404, now we list all path parameters that were used in the API call. This provides clearer error messages that help users identify which parameter might be incorrect.

Example error message:
```
Resource not found. Please verify these parameters are correct:
  - organizationSlug: 'my-org'
  - issueId: 'PROJ-123'
```

Changes:
- Simplified error handling to remove operation tracking
- Tools now only pass path parameters that could cause 404s
- Error messages list all relevant parameters for better debugging

Fixes MCP-SERVER-EA1, MCP-SERVER-E9B

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@dcramer dcramer merged commit c94e2a0 into main Jul 10, 2025
13 checks passed
@dcramer dcramer deleted the improve-404s-2 branch July 10, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant