-
Notifications
You must be signed in to change notification settings - Fork 28
feat: improved settings via env variables #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
- Coverage 59.69% 59.46% -0.23%
==========================================
Files 78 77 -1
Lines 6634 6580 -54
Branches 493 495 +2
==========================================
- Hits 3960 3913 -47
+ Misses 2674 2667 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… and full URL formats Allow SENTRY_HOST to accept either hostname-only (e.g. "sentry.io") or full URL (e.g. "https://sentry.io", "http://localhost:8000") formats. This improves flexibility for self-hosted and local development scenarios while maintaining backwards compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
@@ -58,7 +58,7 @@ OPENAI_API_KEY=your_openai_api_key | |||
SENTRY_ACCESS_TOKEN=your_sentry_access_token | |||
|
|||
# Optional | |||
SENTRY_HOST=https://sentry.io # For self-hosted Sentry instances | |||
SENTRY_HOST=sentry.io # For self-hosted Sentry instances (hostname or full URL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment for SENTRY_HOST
is inconsistent with the implementation. According to the PR changes, SENTRY_HOST
should only accept hostnames without protocols, while SENTRY_URL
should be used for full URLs. The comment should be updated to:
SENTRY_HOST=sentry.io # For self-hosted Sentry instances (hostname only, no protocol)
Additionally, consider adding a line for SENTRY_URL
to show both options:
SENTRY_URL=https://sentry.io # Alternative to SENTRY_HOST, accepts full URLs with protocol
SENTRY_HOST=sentry.io # For self-hosted Sentry instances (hostname or full URL) | |
SENTRY_HOST=sentry.io # For self-hosted Sentry instances (hostname only, no protocol) | |
SENTRY_URL=https://sentry.io # Alternative to SENTRY_HOST, accepts full URLs with protocol |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Validate SENTRY_HOST to only accept hostname (e.g. "sentry.io"). Support SENTRY_URL for URLs (e.g. "https://sentry.io", "http://localhost:8000") - entirely because I'm tired of support tickets.
Remove deprecated SENTRY_AUTH_TOKEN.
Rename MCP_HOST to MCP_URL.
🤖 Generated with Claude Code