-
Notifications
You must be signed in to change notification settings - Fork 28
wip: add event attachment download support #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
379b7d4
to
7bcabc8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 59.37% 58.32% -1.05%
==========================================
Files 49 49
Lines 6038 6263 +225
Branches 472 470 -2
==========================================
+ Hits 3585 3653 +68
- Misses 2453 2610 +157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7bcabc8
to
ae1643a
Compare
Attachments can be listed and downloaded. Text attachments are returned inline with the text response. Binary attachments are included as embedded resource or image content
ae1643a
to
6b909e5
Compare
will work on getting this merged after i land #356 |
Alright merged in #358. Thanks @seanhoughton! |
Attachments can be listed and downloaded. Text attachments are returned inline with the text response. Binary attachments are included as embedded resource.
This is a prototype implementation to address my feature request: #314. It works very well for small-ish text attachments. I think we should consider a size limit and just return the download URL for anything larger than that limit.
I'm also wondering of we should detect image types and return them as
type: "image"
content blocks.I've discovered that VSCode does allow you to download embedded resources, but it's a tiny button that's hidden unless you expand the results of a tool execution. It does not allow you to save the resource to disk as part of the chat.