fix(gatsby): fetching 404 page with path prefix #34237
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add e2e test for PR #32528
Closes #32142 and #31504.
Adds the pathPrefix on the doFetch action that checks for 404 page existence. This previously was called without prefix, causing React to break when the resource existed on the root path or a 302 redirect were returned.
Current behaviour
404 page with
pathPrefix
, brokenReact
rendering (react hydrate), just a static markup( just like only callReactDOMServer.renderToString(<Page-404 />)
)Expected behaviour
React
hydrate success, you can interactive with your gatsby 404 pageRelated Issues
#31504
#31531
#32142