Support graymatter data in asciidoc files #33403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
halkeye
force-pushed
the
asciigraymatter
branch
2 times, most recently
from
31eb12d to
5fb9924
Compare
|
I don't think the failed tests are related to my change :( |
halkeye
force-pushed
the
asciigraymatter
branch
from
5fb9924 to
2748609
Compare
|
Thank you! Is it possible to add an example of grasmatten to the using-asciidoc example 🙏 This allows me to test the PR |
|
Sure. I can take a stab tomorrow night. Can you point me where the examples are? |
KyleAMathews
reviewed
Oct 5, 2021
| @@ -98,6 +113,9 @@ export const pageQuery = graphql` | |||
| authorInitials | |||
| } | |||
| frontmatter { | |||
| source | |||
There was a problem hiding this comment.
none of the example asciidoctor files have frontmatter yet right?
There was a problem hiding this comment.
oh shoot i forgot to git add, which explained why ci failed
halkeye
force-pushed
the
asciigraymatter
branch
from
fc07d9e to
05c02f6
Compare
halkeye
force-pushed
the
asciigraymatter
branch
from
05c02f6 to
73fcc01
Compare
|
Okay, missing files re-added, then rebased ontop of master again |
TylerBarnes
removed
the
status: triage needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for processing graymatter headers inside of asciidoc files
Documentation
At jenkins we use asciidoc for the main website. its already using frontmatter content all over the place. I want to convert to gatsby, so i need to support this
Example: https://github.com/jenkins-infra/jenkins.io/blob/master/content/blog/2021/09/2021-09-04-wiki-attacked.adoc
[X] Update any references, if relevant. This includes Guides and Gatsby Internals docs.
[X] Tag @gatsbyjs/documentation for review, pairing, polishing of the documentation
Related Issues