Skip to content

Set field alias and type for gravity forms plugin #29717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomwhita
Copy link

Description

Declares the GravityForms field alias to support WPGraphQL For Gravity Forms plugin. Add type check.

Replacing PR #29685 with this one to avoid yarn.lock issues.

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 23, 2021
@tomwhita tomwhita closed this Feb 23, 2021
@tomwhita tomwhita reopened this Feb 23, 2021
@TylerBarnes TylerBarnes self-requested a review February 24, 2021 20:13
@TylerBarnes TylerBarnes added topic: source-wordpress Related to Gatsby's integration with WordPress and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 24, 2021
@TylerBarnes TylerBarnes self-assigned this Feb 24, 2021
TylerBarnes
TylerBarnes previously approved these changes Feb 24, 2021
Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for this!

@TylerBarnes TylerBarnes added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 24, 2021
@@ -97,6 +98,7 @@ const remoteSchema: IRemoteSchemaStore = {
internal: `wpInternal`,
plugin: `wpPlugin`,
actionOptions: `wpActionOptions`,
fields: 'wpFields',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinytoolbox This fails our lint checks, please change:

Suggested change
fields: 'wpFields',
fields: `wpFields`,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix applied. Thanks

@tomwhita
Copy link
Author

Will this make it into a release soon?

@justlevine
Copy link

Not sure if this is a separate issue, but while the pr successfully adds wpFields to the schema, the nodes themselves don't resolve to anything.

Gatsby GraphiQL
image

(Working) WPGraphQL
image

The debug generated node-list-query.graphql works fine in WPGraphQL....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants