fix(gatsby-source-drupal): process included nodes on preview and incremental builds #28653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handleWebhookUpdate has to process all nodes at once to ensure proper references between them
pass `included` nodes to `handleWebhookUpdate` and remove the loop to process all nodes at once. else, references among updated or added nodes are potentially not resolved correctly
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: source-drupal
|
@pmelab This PR has conflicts, FYI. |
LekoArts
added
the
topic: source-plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues:
includedwithin Drupal (with JSON:API Extras) are passed, but not processed by Gatsby in the preview or fastbuild updates.Solution
I adapted
handleWebhookUpdateto accept multiple nodes at once and process the references between them correctly to solve issue#1. Then I addedincludedcontent from the json payload to the list of nodes to be processed on preview or fastbuild update.