Tweaks to Trivia::findNodeWhereRangeFitsIn #3169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use Array.tryPick rather than Array.choose |> Array.tryHead - Use Option.orElseWith rather than 'Some betterChild -> Some betterChild'
nojaf
reviewed
Jun 14, 2025
| match betterChildNode with | ||
| | Some betterChild -> Some betterChild | ||
| | None -> Some root | ||
| betterChildNode |> Option.orElseWith (fun () -> Some root) |
There was a problem hiding this comment.
Do you think that would perform better? Or this is more of a "I would have written it that way" thing?
| @@ -158,12 +158,9 @@ let rec findNodeWhereRangeFitsIn (root: Node) (range: range) : Node option = | |||
| // The more specific the node fits the selection, the better | |||
| let betterChildNode = | |||
| root.Children | |||
| |> Array.choose (fun childNode -> findNodeWhereRangeFitsIn childNode range) | |||
| |> Array.tryHead | |||
| |> Array.tryPick (fun childNode -> findNodeWhereRangeFitsIn childNode range) | |||
There was a problem hiding this comment.
This is the real improvement, is it not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #3164 (comment)
Rather trivial in the grand scheme of things, but results of the Benchmarks project:
Before:
After:
My laptop is a bit variable with the runtime, but there' no real time change, just a small memory change (155.61MB to 155.24MB with the tryPick change, and to 155.17MB from orElseWith