Skip to content

GitHub actions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 22, 2020
Merged

GitHub actions #2

merged 15 commits into from
Feb 22, 2020

Conversation

vilinski
Copy link

  • reorganized folders
  • added proposed readme.md
  • added .github/workflows/build.yml with simple dotnet actions

now the last NuGet push action should be completed with source url and nuget key. This could be saved in github repo as secrets

@vilinski vilinski changed the base branch from master to core February 19, 2020 12:56
Copy link
Collaborator

@xperiandri xperiandri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И в ReadMe укажем, что можно брать CI построения с https://www.myget.org/feed/fsharp-collections-immutable/package/nuget/FSharp.Collections.Immutable
Тебе видна эта страница?

<Company>XperiAndri</Company>
<ProductName>FSharp.Collections.Immutable</ProductName>
<Copyright>Copyright © XperiAndri 2016</Copyright>
<Version>0.1.0</Version>
<Authors>XperiAndri;EventHelix</Authors>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавляйся тоже

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

README.md Outdated

F# bindings for System.Collections.Immutable

![.NET Core](https://github.com/vilinski/FSharp.Collections.Immutable/workflows/.NET%20Core/badge.svg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь наверное ссылка должна указывать на файл в репозитории организации fsprojects?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -8,7 +8,7 @@
<Company>XperiAndri</Company>
<ProductName>FSharp.Collections.Immutable</ProductName>
<Copyright>Copyright © XperiAndri 2016</Copyright>
<Version>0.1.0</Version>
<Version>1.0.0</Version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И я видел как-то делают автоинкремент чтобы версия была вида 1.0.0-ci-00003

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И видел где-то библиотеку, чтобы из тегов версию вычитывало и её публиковала

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

есть Fake.Core.SemVer и Fake.Tools.Git, но тогда билдскрипт нужен и в нем все делать

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавил publish.yml отсюда https://github.com/marketplace/actions/publish-nuget
она вынимает версию из проекта и паблишит по коммиту или тегу, если верить описанию. MyGet пуш у меня в бранче не может взять ключ из секретов. может заработает если его в проект смержить...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description почему-то дважды получился

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@xperiandri xperiandri merged commit 4a393d2 into fsprojects:core Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants