Skip to content

automount location: add support for delete_continue. #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rjeffman
Copy link
Member

@rjeffman rjeffman commented Feb 7, 2022

Add support for attribute 'delete_continue' in ipaautomountlocation.

Must not be merged before #761.

Fix #620

@rjeffman rjeffman requested a review from t-woerner February 7, 2022 20:55
@rjeffman
Copy link
Member Author

rjeffman commented Feb 7, 2022

This is intersting... on my machine with ansible-core 2.12.1, ansible-doc works and generates the expected documentation, but on the Github workflow, it fails.

(sanity.sh is also successful on my machine.)

@rjeffman rjeffman force-pushed the delete_continue_automountlocation branch 2 times, most recently from 539fe01 to b4f4611 Compare February 8, 2022 18:46
@@ -111,5 +112,6 @@
- TestLocation_03
- TestLocation_04
state: absent
continue: yes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjeffman In this playbook you are just ensuring TestLocation_01, TestLocation_02, TestLocation_03, TestLocation_04 are already removed, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally, only TestLocation_01 and TestLocation_02 were created, and at this point, both should already be removed. TestLocation_03 and TestLocation_04 were never created. I'm not sure why the original author created this test in this way.

I'm not sure how to properly test delete_continue, so all I'm doing here is ensuring that its presence does not change the expected result of existing tests.

t-woerner added a commit to t-woerner/ansible-freeipa that referenced this pull request Feb 14, 2022
…ragments

The script now fixes the references for all doc_fragments in the
plugins/doc_fragments folder. So far it was only fixing the references
for ipamodule_base_docs.

PR freeipa#762 (automount location: add support for delete_continue) added an
other doc_fragment and the references have not been fixes as needed.
@rjeffman rjeffman force-pushed the delete_continue_automountlocation branch 2 times, most recently from 1a189ee to c04c8a0 Compare February 15, 2022 20:36
Add support for attribute 'delete_continue' in ipaautomountlocation.
@rjeffman rjeffman force-pushed the delete_continue_automountlocation branch from c04c8a0 to c509c1f Compare February 17, 2022 17:26
@rjeffman rjeffman removed the blocked label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipautomountlocation: Add support for "continue" attribute
2 participants