-
Notifications
You must be signed in to change notification settings - Fork 81
chore: add support for dev containers #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces Dev Container support for the repository. It adds the necessary configuration files ( No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a
.dockerignore
file to reduce the size of the image built by the dev container. - The
command: sleep infinity
indocker-compose.yml
is a common trick, but consider using a more descriptive command or a health check.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Adds support for Dev Containers in our repository.
What is a Dev Container ?
A development container (or dev container for short) allows you to use a container as a full-featured development environment. It can be used to run an application, to separate tools, libraries, or runtimes needed for working with a codebase, and to aid in continuous integration and testing.
Think of working in a development container as running a project inside a Docker container.
With a Dev Container, the idea is that you don't have to spend time on setting up the dev env on your own PC. All the dependencies and tools are already set up inside the container.
Demonstration
A video demonstration on how to build the firmware inside the Dev Container:
dev_container.mp4
Summary by Sourcery
Add support for development containers to simplify project setup and development environment configuration
New Features:
Documentation:
Chores: