NEW: @W-19160212@: Unify quick fix experience and prepare ApexGuru violations to use it #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-carter-at-sf
force-pushed
the
sc/W-19160212
branch
from
91cc35b to
d6ab887
Compare
stephen-carter-at-sf
force-pushed
the
sc/W-19160212
branch
from
fdf3ad7 to
f5746ce
Compare
| expect(diagnostics[0].relatedInformation[1].message).to.equal(`/*\n//ApexGuru Suggestions: \n${expectedSuggestedCode}\n*/`); | ||
| }); | ||
|
|
||
| test('Transforms valid JSON string to Violations for code violations', () => { |
There was a problem hiding this comment.
This entire legacy test seems to be a duplicate of the one above it.
stephen-carter-at-sf
requested review from
jfeingold35,
randi274 and
jshackell-sfdc
randi274
reviewed
Aug 6, 2025
| // Technically, I don't think VS Code sends in diagnostics that aren't overlapping with the users selection, | ||
| // but just in case they do, then this last filter is an additional sanity check just to be safe | ||
| .filter(d => range.intersection(d.range) != undefined); | ||
|
|
||
| if (filteredDiagnostics.length == 0) { | ||
| return codeActions; |
There was a problem hiding this comment.
Nice, this reads much cleaner 👍
randi274
reviewed
Aug 6, 2025
| violation.fixes = [ | ||
| { | ||
| location: violationLocation, | ||
| fixedCode: `/*\n//ApexGuru Suggestions: \n${suggestedCode}\n*/` |
There was a problem hiding this comment.
Suggested change
| fixedCode: `/*\n//ApexGuru Suggestions: \n${suggestedCode}\n*/` | |
| fixedCode: `/*\n//ApexGuru Fixes: \n${suggestedCode}\n*/` |
There was a problem hiding this comment.
This is all temporary (as an intermediate of the old pilot world) - it's just fluff until we get the real responses from the ApexGuru team (which is a separate work item for us to encorporate)... so I just left things as similar as they were before.
jfeingold35
reviewed
Aug 6, 2025
There was a problem hiding this comment.
Nitpick: There's a typo in the file name.
There was a problem hiding this comment.
OK fixed. Good catch.
randi274
approved these changes
Aug 6, 2025
stephen-carter-at-sf
force-pushed
the
sc/W-19160212
branch
from
f5746ce to
0c90346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.