W-18989201 fix: file parsing bug #6405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
commented
Jul 8, 2025
| ) | ||
| .flat() | ||
| // parsing to string for set to dedupe, then back to URI | ||
| .map(uri => uri.toString()) |
There was a problem hiding this comment.
this slipped by the compiler because without flat you have URI[] instead of URI
BUT array has a toString method so the compiler thought this was fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix a types bug that probably causes apex test diagnostics to not be applied to a file. I don't know how to reproduce this or exactly what it should look like, but I know the code is wrong!
What issues does this PR fix or reference?
@W-18989201@