-
Notifications
You must be signed in to change notification settings - Fork 420
[W-18337597] refactor: remove deprecated ConfigGet #6403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W-18337597] refactor: remove deprecated ConfigGet #6403
Conversation
.vscode/settings.json
Outdated
@@ -33,5 +33,6 @@ | |||
"prettier.useTabs": false, | |||
"prettier.printWidth": 120, | |||
"prettier.arrowParens": "avoid", | |||
"editor.rulers": [120] | |||
"editor.rulers": [120], | |||
"cSpell.words": ["debugadapter", "debugprotocol", "salesforcedx", "STREAMINGAPI", "testsupport"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @mshanemc suggested, I installed the Code Spell Checker VSCode extension. These are some words in our code that had blue squiggly lines, which I added to the dictionary. As I come across more blue squigglies in our code, I'll continue to populate this list, and I'm hoping to see contributions from the team as we visit files across the codebase in our refactoring. 🙂
…ggregator() and externalize vscode in bundling
packages/salesforcedx-apex-debugger/src/context/isvContextUtil.ts
Outdated
Show resolved
Hide resolved
packages/salesforcedx-apex-debugger/src/context/isvContextUtil.ts
Outdated
Show resolved
Hide resolved
packages/salesforcedx-apex-debugger/src/context/isvContextUtil.ts
Outdated
Show resolved
Hide resolved
…Util.ts directly into isvContext.ts
…remove-deprecated-configGet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?
Replaces the deprecated
ConfigGet
withConfigAggregator
from@salesforce/core-bundle
. No change in functionality.What issues does this PR fix or reference?
@W-18337597@