Skip to content

[W-18337597] refactor: remove deprecated ConfigGet #6403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 10, 2025

Conversation

daphne-sfdc
Copy link
Contributor

@daphne-sfdc daphne-sfdc commented Jul 7, 2025

What does this PR do?

Replaces the deprecated ConfigGet with ConfigAggregator from @salesforce/core-bundle. No change in functionality.

What issues does this PR fix or reference?

@W-18337597@

@daphne-sfdc daphne-sfdc requested a review from mshanemc July 7, 2025 22:28
@daphne-sfdc daphne-sfdc requested a review from a team as a code owner July 7, 2025 22:28
@@ -33,5 +33,6 @@
"prettier.useTabs": false,
"prettier.printWidth": 120,
"prettier.arrowParens": "avoid",
"editor.rulers": [120]
"editor.rulers": [120],
"cSpell.words": ["debugadapter", "debugprotocol", "salesforcedx", "STREAMINGAPI", "testsupport"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @mshanemc suggested, I installed the Code Spell Checker VSCode extension. These are some words in our code that had blue squiggly lines, which I added to the dictionary. As I come across more blue squigglies in our code, I'll continue to populate this list, and I'm hoping to see contributions from the team as we visit files across the codebase in our refactoring. 🙂

@daphne-sfdc daphne-sfdc changed the title [W-18337597] remove deprecated ConfigGet [W-18337597] refactor: remove deprecated ConfigGet Jul 10, 2025
@daphne-sfdc daphne-sfdc requested a review from mshanemc July 10, 2025 18:50
Copy link
Contributor

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-07-10 at 3 46 16 PM good ratio!

@mshanemc mshanemc merged commit b68abac into develop Jul 10, 2025
8 checks passed
@mshanemc mshanemc deleted the daphne/W-18337597-remove-deprecated-configGet branch July 10, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants