Skip to content

[W-18338037] refactor: metadataDescribe without cli #6401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 7, 2025
Merged

[W-18338037] refactor: metadataDescribe without cli #6401

merged 11 commits into from
Jul 7, 2025

Conversation

daphne-sfdc
Copy link
Contributor

@daphne-sfdc daphne-sfdc commented Jul 5, 2025 •
edited
Loading

What does this PR do?

  1. Refactors the code in describeMetadata.ts to not call the CLI command.
  2. Improved the user experience so that when switching between orgs, the org browser automatically displays the metadata for the new org. Users no longer have to click the "SFDX: Refresh Types" button every time they set a new default org.
  3. Fixed a bug to display a meaningful error message when the default org is expired and the "SFDX: Refresh Types" button is clicked.

Test plan here: https://salesforce.quip.com/SsuWAVziG1OT

What issues does this PR fix or reference?

@W-18338037@

@daphne-sfdc daphne-sfdc requested a review from mshanemc July 5, 2025 16:31
@daphne-sfdc daphne-sfdc requested a review from a team as a code owner July 5, 2025 16:31
mshanemc
mshanemc approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA notes:
ran org browser, works
file was written
deleted the entire orgs/____/metadata dir
reloaded and saw file rewritten

@mshanemc mshanemc merged commit 31b5c9e into develop Jul 7, 2025
8 checks passed
@mshanemc mshanemc deleted the daphne/W-18338037-metadataDescribe-without-cli branch July 7, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshanemc mshanemc mshanemc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daphne-sfdc @mshanemc