feat: W-18338854 - execute soql query commands don't rely on CLI anymore #6400
Conversation
|
|
||
| // Open the file in editor | ||
| const document = await vscode.workspace.openTextDocument(filePath); | ||
| await vscode.window.showTextDocument(document); |
There was a problem hiding this comment.
Running queries is an async task, do we really want to force a focus change in the UI?
There was a problem hiding this comment.
good point. preserveFocus:false would open the document but not steal focus? Or are you thinking of something else?
There was a problem hiding this comment.
I was thinking to show the success notification and a "Open file" button in case the user wants to review it. Wdyt?
|
|
||
| // Open the file in editor | ||
| const document = await vscode.workspace.openTextDocument(filePath); | ||
| await vscode.window.showTextDocument(document); |
There was a problem hiding this comment.
good point. preserveFocus:false would open the document but not steal focus? Or are you thinking of something else?
…x-vscode into cristi/queryUser
There was a problem hiding this comment.
code:
❌ linter warnings are no good. I'm going to fix those with some PR/types changes.
QA notes:
✅ queries fine when entering the query
✅ good error when I do an invalid query
❌ see comment about blank line in output being non-reproducible
✅ did SELECT COUNT() FROM Property__c from highlighted text in dreamhouse repo, got fine result
mshanemc
dismissed
peternhale’s stale review
resolved (requires button click in notification to view the results csv)
What does this PR do?
This pull request introduces significant enhancements to the SOQL query execution functionality in the
dataQuery.tsfile. The changes include refactoring theDataQueryExecutorclass to use theLibraryCommandletExecutor, improving error handling, introducing CSV export capabilities, and updating i18n messages for better user feedback.Enhancements to SOQL Query Execution:
DataQueryExecutorto useLibraryCommandletExecutorfor improved handling of SOQL queries. Added methods for executing queries, displaying results in a table format, converting results to CSV, and saving them to a file. Enhanced error handling to provide specific messages for common issues, such as session expiration or malformed queries.Improvements to API Type Handling:
ApiTypeenum to use uppercase naming (TOOLINGinstead ofTooling) for consistency.ApiType.Toolingin theGetQueryAndApiInputsclass to align with the updated enum naming convention.Updates to i18n Messages:
What issues does this PR fix or reference?
@W-18338854@