W-18965616 refactor: eslint nullish #6398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daphne-sfdc
requested review from
daphne-sfdc
and removed request for
mingxuanzhangsfdx
…vscode into sm/nullish
…vscode into sm/nullish
daphne-sfdc
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mostly https://typescript-eslint.io/rules/prefer-nullish-coalescing/
but 3 packages can't take the rule
also includes a little cursor plan for what's different between this repo and the salesforce standard one the CLI uses (not too much left to be able to align). We can then start propagating that dependency to our other repos.
What issues does this PR fix or reference?
@W-18965616@