@W-18962079 refactor: unused-vars #6396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daphne-sfdc
requested review from
daphne-sfdc
and removed request for
klewis-sfdc
daphne-sfdc
reviewed
Jul 3, 2025
There was a problem hiding this comment.
E2E test run at this point: https://github.com/forcedotcom/salesforcedx-vscode/actions/runs/16058719849
packages/salesforcedx-utils/test/jest/i18n/advancedLocalization.test.ts
Outdated
Show resolved
Hide resolved
packages/salesforcedx-utils-vscode/src/commands/preconditionCheckers.ts
Outdated
Show resolved
Hide resolved
packages/salesforcedx-vscode-apex-replay-debugger/src/breakpoints/checkpointService.ts
Show resolved
Hide resolved
daphne-sfdc
approved these changes
Jul 5, 2025
There was a problem hiding this comment.
E2E test run: https://github.com/forcedotcom/salesforcedx-vscode/actions/runs/16060105919
Manual testing:
Mac:
- Deploy and Retrieve ✅
- Push and Pull ✅
Ubuntu:
- Create OAS Doc ✅
- Deploy and Retrieve ✅
- Push and Pull ✅
Windows:
- Create OAS Doc ✅
- Apex LSP ✅
- Debug Apex Tests ✅
- Run Apex Tests ✅
- Deploy and Retrieve ✅
- Manifest Builder ✅
- Push and Pull ✅
- LWC LSP ✅
- Debug LWC Tests ✅
- Run LWC Tests ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
primary:
_foothat are intentionally unused. Usually, it's because we have to match an interface for OOPextendsreasons, but should keep us from introducing more of them unintentionally.other
dedupe: core ext uses SfWorkspaceChecker from utils instead of its own local copy
removed the Predicate stuff
removed the unused stuff related to
getTelemetryDataon sfCommandletExecutor (also verified a4d ext isn't using it)fix some promise handling (async vs. not)
@W-18962079@