-
Notifications
You must be signed in to change notification settings - Fork 420
refactor: W-18488820 - last of fs and eslint rule #6390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CristiCanizales
wants to merge
30
commits into
develop
Choose a base branch
from
cristi/last-fs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+163
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
Jul 2, 2025
packages/salesforcedx-apex-replay-debugger/src/core/logContext.ts
Outdated
Show resolved
Hide resolved
mshanemc
reviewed
Jul 2, 2025
packages/salesforcedx-apex-replay-debugger/test/unit/adapter/apexReplayDebug.test.ts
Outdated
Show resolved
Hide resolved
mshanemc
reviewed
Jul 2, 2025
mshanemc
reviewed
Jul 2, 2025
mshanemc
reviewed
Jul 2, 2025
mshanemc
reviewed
Jul 2, 2025
packages/salesforcedx-utils-vscode/test/jest/helpers/fs.test.ts
Outdated
Show resolved
Hide resolved
mshanemc
reviewed
Jul 2, 2025
packages/salesforcedx-visualforce-language-server/test/jest/formatting.test.ts
Outdated
Show resolved
Hide resolved
mshanemc
reviewed
Jul 2, 2025
packages/salesforcedx-vscode-apex-replay-debugger/src/activation/getDialogStartingPath.ts
Outdated
Show resolved
Hide resolved
mshanemc
reviewed
Jul 2, 2025
mshanemc
reviewed
Jul 2, 2025
mshanemc
requested changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comments. I think fixing the rule to only be node:fs
will make this all easier.
…vscode into cristi/last-fs
…edx-vscode into cristi/last-fs
…vscode into cristi/last-fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request introduces several updates across the codebase, focusing on improving code quality, enforcing stricter linting rules, transitioning to asynchronous patterns, and enhancing compatibility with web extensions. Below is a summary of the most important changes grouped by theme.
Linting and Code Quality Improvements:
@typescript-eslint/no-floating-promises
fromwarn
toerror
to enforce stricter handling of unresolved promises. (eslint.config.mjs
, eslint.config.mjs L133-R133)no-restricted-imports
rule to restrict usage of Node.jsfs
andfs-extra
modules, recommending the use of VSCode'sfs
API for compatibility with web extensions. (eslint.config.mjs
, eslint.config.mjs R290-R301)Asynchronous Code Transition:
ApexDebugForTest
class, ensuring proper handling of asynchronous operations. (apexDebugForTest.ts
, packages/salesforcedx-apex-debugger/test/unit/adapter/apexDebugForTest.ts L103-R117)apexDebug.test.ts
andcommandOutput.test.ts
to useawait
for testing asynchronous methods, improving reliability and readability. (apexDebug.test.ts
, [1];commandOutput.test.ts
, [2]Debugger Enhancements:
ApexReplayDebug
class for better readability and maintainability. (apexReplayDebug.ts
, [1] [2]Compatibility Updates:
packages/salesforcedx-apex-replay-debugger
directory to the ESLint configuration, ensuring it adheres to the project's linting rules. (eslint.config.mjs
, eslint.config.mjsR410)no-restricted-imports
rule in specific files where usage of Node.jsfs
is necessary for integration tests. (logContextUtil.ts
, [1];goldFileUtil.ts
, [2]Miscellaneous Improvements:
tsconfig.json
, packages/salesforcedx-apex-replay-debugger/tsconfig.jsonL5-R7)dispose
method inappInsights.ts
to usevoid
for clarity in asynchronous contexts. (appInsights.ts
, packages/salesforcedx-utils-vscode/src/telemetry/reporters/appInsights.tsL49-R49)What issues does this PR fix or reference?
@W-18488820@