Skip to content

Prerelease/dev #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 301 commits into
base: main
Choose a base branch
from
Open

Prerelease/dev #52

wants to merge 301 commits into from

Conversation

madhur310
Copy link
Collaborator

PR to update the module so it is npm publishable.

- DEV_HUB_ALIAS_NAME
| Environment Variable | Description | Default Value |
| ------------------------------------- | ----------------------------------------------------------------------------------------------------- | -------------------------------------------- |
| `CODE_VERSION` | VSCode version to use in tests | `'latest'` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `CODE_VERSION` | VSCode version to use in tests | `'latest'` |
| `VSCODE_VERSION` | VSCode version to use in tests | `'latest'` |

Comment on lines +119 to +120
| `DEV_HUB_ALIAS_NAME` | Alias for the DevHub org | `'vscodeOrg'` |
| `DEV_HUB_USER_NAME` | Username for the DevHub org | `'[email protected]'` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have these values as default for everyone

| `DEV_HUB_ALIAS_NAME` | Alias for the DevHub org | `'vscodeOrg'` |
| `DEV_HUB_USER_NAME` | Username for the DevHub org | `'[email protected]'` |
| `SFDX_AUTH_URL` | URL for authenticating with Salesforce DX | `undefined` |
| `EXTENSION_PATH` | Path to extensions directory | `{cwd}/../../salesforcedx-vscode/extensions` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extension path doesn't need to be this one for everyone


- EXTENSION_PATH
- **SFDX_AUTH_URL**: To obtain this URL, run `sf org display -o vscodeOrg --verbose --json` in your terminal and extract the value from the `sfdxAuthUrl` property
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **SFDX_AUTH_URL**: To obtain this URL, run `sf org display -o vscodeOrg --verbose --json` in your terminal and extract the value from the `sfdxAuthUrl` property
- **SFDX_AUTH_URL**: To obtain this URL, run `sf org display -o <myDevHub> --verbose --json` in your terminal and extract the value from the `sfdxAuthUrl` property

steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.release.tag_name || inputs.tag }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's going main, this file needs some updates.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning that as a follow up task: https://gus.lightning.force.com/a07EE00002Hq3jaYAB

package.json Outdated
@@ -20,39 +105,52 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/forcedotcom/salesforcedx-vscode-automation-tests-redhat.git"
"url": "git+https://github.com/forcedotcom/salesforcedx-vscode-test-tools.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably rename the repo at some point: https://gus.lightning.force.com/a07EE00002HsxsGYAR

but yes this can be changed then

@@ -0,0 +1 @@
404: Not Found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh? maybe delete this file if it's not needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, will do.

import path from 'path';
import fs from 'fs-extra';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just use fs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can, this is cursor's doing didn't catch it. Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants