Skip to content

Fixes: toast messages never hide #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BF4C5B1330
Copy link

Probably only happens at certain resolution+margins combos.
I guess I was unlucky enough that my y ended up in a decimal.

Full error as follows:

\SFDX-Data-Move-Utility-Desktop-App\js\services\browser-console-service.js:55
LOG MESSAGE:ERROR: [\SFDX-Data-Move-Utility-Desktop-App\node_modules\@electron\remote\dist\src\main\server.js:465:71:465] 
Error: An unhadled exception occured in the renderer process: Uncaught Error: Could not call remote method 'setPosition'. Check that the method signature is correct. Underlying error: TypeError: Error processing argument at index 0, conversion failure from Underlying stack: TypeError: Error processing argument at index 0, conversion failure from 
    at \SFDX-Data-Move-Utility-Desktop-App\node_modules\@electron\remote\dist\src\main\server.js:465:71
    at IpcMainImpl.<anonymous> (\SFDX-Data-Move-Utility-Desktop-App\node_modules\@electron\remote\dist\src\main\server.js:323:27)
    at IpcMainImpl.emit (node:events:513:28)
    at EventEmitter.<anonymous> (node:electron/js2c/browser_init:2:82193)
    at EventEmitter.emit (node:events:513:28)
 (\SFDX-Data-Move-Utility-Desktop-App\js\electron-app\preload.js:21)
    at windowOnError (\SFDX-Data-Move-Utility-Desktop-App\js\electron-app\preload.js:14:39)
    at windowOnUnhandledRejection (\SFDX-Data-Move-Utility-Desktop-App\js\electron-app\preload.js:21:9).
consoleError @ \SFDX-Data-Move-Utility-Desktop-App\js\services\browser-console-service.js:55
_formatMessage @ \SFDX-Data-Move-Utility-Desktop-App\js\services\log-service.js:147
errorEx @ \SFDX-Data-Move-Utility-Desktop-App\js\services\log-service.js:100
windowOnError @ \SFDX-Data-Move-Utility-Desktop-App\js\electron-app\preload.js:14
windowOnUnhandledRejection @ \SFDX-Data-Move-Utility-Desktop-App\js\electron-app\preload.js:21

`setPosition` only accepts integer numbers. [1]
Fixes error: `TypeError: Error processing argument at index 0, conversion failure`
Fixes functionality: toast messages never hide.

[1] https://www.electronjs.org/docs/latest/api/browser-window#winsetpositionx-y-animate
Copy link

Thanks for the contribution! Before we can merge this, we need @BF4C5B1330 to sign the Salesforce Inc. Contributor License Agreement.

@BF4C5B1330
Copy link
Author

BF4C5B1330 commented Apr 16, 2025

EDIT: visiting the "sign in" link above yields:

You already signed the CLA on 2025-04-16

...so I guess it did go through, but is not reflected/linked here properly.

Incidentally, the other PR I opened signed itself just fine. So maybe there was a hiccup first time.


ℹ️ CLA crashed out, saying to contact [email protected]
Would you consider this my consent instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant