-
Notifications
You must be signed in to change notification settings - Fork 46
Update minimum iOS version #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the project's minimum iOS and tvOS deployment targets to 15.0. This is a necessary change to maintain compatibility with recent Firebase iOS dependency updates. The changes involve modifying various project settings files for test applications, updating CMake build configurations, and documenting the new requirement.
Highlights
- Minimum iOS Version Update: The minimum iOS deployment target has been updated from 13.0 to 15.0 across various test applications and build configurations. This change is driven by updated minimum version requirements from Firebase iOS dependencies.
- Build Configuration Alignment: The
DEFAULT_MIN_TARGET_SDK
in the CMake configuration for play services resolver dependencies has been updated to 15.0 to reflect the new minimum iOS version. - Documentation Update: The
readme.md
file has been updated to include a note in the 'Upcoming Changes' section, explicitly stating that the minimum iOS deployment target is now 15.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the minimum iOS deployment target to 15.0 across various configuration files. There are also updates to the tvOS deployment target in some files, but not all. The release notes and the xcode project file should be updated to reflect this.
Description
Update the minimum iOS version to 15.0. This is needed since the Firebase iOS dependencies have updated their minimum to 15.
Testing
https://github.com/firebase/firebase-unity-sdk/actions/runs/16358032875
Type of Change
Place an
x
the applicable box: