Skip to content

🐛 Fix launch to pass wait and locate parameters to click.launch #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

phamour
Copy link

@phamour phamour commented Apr 30, 2025

typer.launch("/path/to/file", locate=True) didn't work as expected:

  • on Windows, it returned 127 without openning any explorer or browser
  • on macOS, it returned 0 with Finder session openned but located to hard drive's root

However, click.launch("/path/to/file", locate=True) did work well both on Windows and Linux.

The reason was not passing locate=True when calling click.launch in typer.launch.

Tested on Windows and macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant