-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Add variable size prefix for key generator class + improve documentation #13709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KareemOtoum
wants to merge
6
commits into
facebook:main
Choose a base branch
from
KareemOtoum:microbench/keygenerator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−27
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e75c9f8
improve keygenerator class documentation
KareemOtoum 8500704
add variable prefix size to keygenerator class + imrpove documentation
KareemOtoum e117b07
ensure backward compatability for encoding prefix and key nums
KareemOtoum 576d2a0
refactor Next function
KareemOtoum 1634807
Merge branch 'main' into microbench/keygenerator
KareemOtoum 81d4333
Merge branch 'facebook:main' into microbench/keygenerator
KareemOtoum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
refactor Next function
commit 576d2a0b2396c632e2625ccdb4a0efab09acffb2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that as of now, the encode function can only encode up to 4 bytes for the prefix/key, I am planning on changing this with my next pr where I will look at extending the max number of keys that can be generated.