Fix DB open failure caused by duplicate VersionEdit records in MANIFEST

[gitccl]

As described in #13624 , this PR fixes a DB open failure caused by duplicate VersionEdit records in the MANIFEST. The issue stems from a bug in FIFO compaction in older versions of RocksDB that could write multiple identical VersionEdit records to the MANIFEST, leading to DB::Open() failures in newer versions.

This patch introduces an option to allow duplicated deletion during recovery, enabling affected DBs to be opened successfully.

close #13624

[facebook-github-bot]

Hi @gitccl!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[gitccl]

cc @cbi42 @pdillinger

[gitccl]

Hi @pdillinger @cbi42 @hx235 @jaykorean, This PR has been open for a while, and I’d really appreciate any feedback or suggestions on how to move it forward. Please let me know if there’s anything I can improve or adjust.