Skip to content

fix(file): exit 13 on os error 13 #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 14, 2023
Merged

fix(file): exit 13 on os error 13 #319

merged 7 commits into from
Sep 14, 2023

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Sep 14, 2023

Signed-off-by: Christina Sørensen [email protected]

Closes: #317

@cafkafk cafkafk self-assigned this Sep 14, 2023
Copy link
Contributor

@MartinFillon MartinFillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/fs/dir.rs Outdated
@@ -42,6 +42,7 @@ impl Dir {
.map(|result| result.map(|entry| entry.path()))
.collect::<Result<_, _>>()?;

info!("Read directory succes {:?}", &path);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
info!("Read directory succes {:?}", &path);
info!("Read directory success {:?}", &path);

@cafkafk
Copy link
Member Author

cafkafk commented Sep 14, 2023

@asahi-m do you think exiting with 13 makes sense, or what are you expecting?

cafkafk and others added 3 commits September 14, 2023 16:24
Co-authored-by: Preston Thorpe <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
Co-authored-by: MartinFillon <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
Co-authored-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
@cafkafk cafkafk merged commit 86ad527 into main Sep 14, 2023
@cafkafk cafkafk deleted the cafk-exit-13 branch September 14, 2023 15:08
cafkafk added a commit that referenced this pull request Oct 3, 2023
Ref: #473, #319
Signed-off-by: Christina Sørensen <[email protected]>
@cafkafk cafkafk mentioned this pull request Oct 3, 2023
7 tasks
MartinFillon pushed a commit to MartinFillon/eza that referenced this pull request Oct 11, 2023
Omnikron13 pushed a commit to Omnikron13/eza that referenced this pull request Mar 17, 2024
Closes: eza-community#319

Signed-off-by: Christina Sørensen <[email protected]>
Omnikron13 pushed a commit to Omnikron13/eza that referenced this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

bug: eza exits successfully when os error 13 occurs
3 participants