fix: align getImageSource with community package #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vonovak
force-pushed
the
vonovak/fix_align_getimagesource_with_community_package
branch
from
fcbd8e7 to
6687fe2
Compare
vonovak
force-pushed
the
vonovak/fix_align_getimagesource_with_community_package
branch
from
6687fe2 to
a38dce1
Compare
vonovak
deleted the
vonovak/fix_align_getimagesource_with_community_package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should return the same shape of data as in https://github.com/oblador/react-native-vector-icons/blob/d1828468880af3b8289c3017cb4213fbad7ba977/packages/common/src/create-icon-set.tsx#L211 to make transitioning easy.