[expo-media-library][iOS] add support for filtering assets by media subtype #36756
Conversation
|
Subscribed to pull request
Generated by CodeMention |
expo-bot
added
bot: passed checks
|
@vonovak thanks for self-assigning this. idk how to re-run the |
can you please rebase this on latest |
There was a problem hiding this comment.
Thank you for the PR!
I believe mediaSubtypes need to receive the arrayize treatment like here
Also if you could add an example of this in one of the screens here that'd be great - it'll speed up the review process, though not strictly necessary.
Also pls rebase on latest main.
Thank you!
.yarnrc.yml
Outdated
| @@ -0,0 +1 @@ | |||
| nodeLinker: node-modules | |||
There was a problem hiding this comment.
let's remove this file pls
|
@clarkg hello, can you please resolve the review comments? |
Co-authored-by: Expo Bot <[email protected]>
expo-bot
added
bot: suggestions
expo-bot
added
bot: passed checks
| @@ -2,38 +2,6 @@ import ExpoModulesCore | |||
| import Photos | |||
| import CoreServices | |||
|
|
|||
| func stringify(mediaType: PHAssetMediaType) -> String { | |||
There was a problem hiding this comment.
moved this to MediaType.init(fromPHAssetMediaType mediaType: PHAssetMediaType) to prevent the two from going out of sync
| } | ||
|
|
||
| func stringifyMedia(mediaSubtypes: PHAssetMediaSubtype) -> [String] { | ||
| let subtypesDict: [String: PHAssetMediaSubtype] = [ |
There was a problem hiding this comment.
moved to MediaSubtype.stringify
|
oh wow thank you @vonovak ! |
Why
this would be very convenient to be able to filter for screenshots, for example, without needing to overfetch
How
extended
AssetOptionswithmediaSubtypesmain logic implemented in
getAssetsWithAfterinMediaLibraryUtilities.swiftTest Plan
test-suite
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).