Skip to content

feat: urlRewrite supports idleTimeout #6561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

mabdh
Copy link
Contributor

@mabdh mabdh commented Jul 19, 2025

What type of PR is this?
feat: urlRewrite supports idleTimeout

What this PR does / why we need it:
The idleTimeout is ignored in HTTPRoute if there is urlRewrite. This PR fixes it so idleTimeout is applicable with urlRewrite.

Which issue(s) this PR fixes:
Fixes #6530

@mabdh mabdh requested a review from a team as a code owner July 19, 2025 02:34
Copy link

codecov bot commented Jul 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.18%. Comparing base (5f30228) to head (879ae7d).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6561      +/-   ##
==========================================
+ Coverage   70.80%   71.18%   +0.37%     
==========================================
  Files         220      220              
  Lines       37820    37972     +152     
==========================================
+ Hits        26780    27030     +250     
+ Misses       9480     9373     -107     
- Partials     1560     1569       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team July 21, 2025 22:08
@arkodg arkodg added this to the v1.5.0-rc.1 Release milestone Jul 21, 2025
@zhaohuabing zhaohuabing merged commit b1f98a9 into envoyproxy:main Jul 22, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idle timeout logic skips routes with url rewrite
3 participants