Skip to content

feat: support stream idle timeout #6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

mabdh
Copy link
Contributor

@mabdh mabdh commented Jul 8, 2025

What type of PR is this?
feat: support stream idle timeout

What this PR does / why we need it:

  • Currently there is no way to configure stream idle timeout of envoy where the default value is 5 mins
  • The max timeout of HTTP is capped to 5 mins
  • This PR Exposes stream idle timeout of envoy so max timeout could be adjusted and increased more

Which issue(s) this PR fixes:
Fixes #4349

@mabdh mabdh requested a review from a team as a code owner July 8, 2025 04:19
@mabdh mabdh mentioned this pull request Jul 8, 2025
@arkodg arkodg added this to the v1.5.0-rc.1 Release milestone Jul 8, 2025
arkodg
arkodg previously approved these changes Jul 8, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team July 8, 2025 22:25
guydc
guydc previously approved these changes Jul 9, 2025
@mabdh mabdh dismissed stale reviews from guydc and arkodg via c4b189d July 9, 2025 11:24
@mabdh mabdh force-pushed the support-stream-idle-timeout branch 5 times, most recently from 63ae033 to 075bd1d Compare July 9, 2025 11:30
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.64%. Comparing base (4140f61) to head (724327a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/clienttrafficpolicy.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6481      +/-   ##
==========================================
- Coverage   70.74%   70.64%   -0.11%     
==========================================
  Files         220      220              
  Lines       37594    37686      +92     
==========================================
+ Hits        26596    26622      +26     
- Misses       9431     9500      +69     
+ Partials     1567     1564       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkodg
arkodg previously approved these changes Jul 9, 2025
@arkodg
Copy link
Contributor

arkodg commented Jul 9, 2025

@mabdh CI is failing, you may need to make generate && make manifests and commit those changes

@mabdh mabdh force-pushed the support-stream-idle-timeout branch from 43631f7 to e37634c Compare July 9, 2025 22:26
@mabdh
Copy link
Contributor Author

mabdh commented Jul 9, 2025

@arkodg updated. thanks for the feedback.

arkodg
arkodg previously approved these changes Jul 9, 2025
guydc
guydc previously approved these changes Jul 9, 2025
@mabdh
Copy link
Contributor Author

mabdh commented Jul 10, 2025

Some ci jobs are still failing. Let me check those.

@mabdh mabdh dismissed stale reviews from guydc and arkodg via 5f93c2c July 10, 2025 01:48
@mabdh mabdh force-pushed the support-stream-idle-timeout branch from 5f93c2c to 724327a Compare July 10, 2025 01:49
@mabdh
Copy link
Contributor Author

mabdh commented Jul 10, 2025

/retest

@arkodg arkodg merged commit 9d2b27d into envoyproxy:main Jul 10, 2025
29 checks passed
tjvdmolen pushed a commit to tjvdmolen/gateway that referenced this pull request Jul 11, 2025
* feat: support stream idle timeout

Signed-off-by: Muhammad Abduh <[email protected]>
Signed-off-by: Tjeerd Jan van der Molen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support StreamIdleTimeout
3 participants