-
Notifications
You must be signed in to change notification settings - Fork 518
feat: support stream idle timeout #6481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
63ae033
to
075bd1d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6481 +/- ##
==========================================
- Coverage 70.74% 70.64% -0.11%
==========================================
Files 220 220
Lines 37594 37686 +92
==========================================
+ Hits 26596 26622 +26
- Misses 9431 9500 +69
+ Partials 1567 1564 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@mabdh CI is failing, you may need to |
Signed-off-by: Muhammad Abduh <[email protected]>
43631f7
to
e37634c
Compare
@arkodg updated. thanks for the feedback. |
Some ci jobs are still failing. Let me check those. |
Signed-off-by: Muhammad Abduh <[email protected]>
5f93c2c
to
724327a
Compare
/retest |
* feat: support stream idle timeout Signed-off-by: Muhammad Abduh <[email protected]> Signed-off-by: Tjeerd Jan van der Molen <[email protected]>
What type of PR is this?
feat: support stream idle timeout
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4349