Add openai and wildcard paths #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for OpenAI-specific URL patterns and wildcard path matching to the proxy application. The changes enable the proxy to handle different URL structures that clients might use when connecting to OpenAI-compatible APIs.
- Adds OpenAI-specific deployment path format with "/openai/" in the URL structure
- Introduces wildcard path support to catch various subpath patterns
- Maintains existing deployment path functionality
| @app.post("/provider/{provider}/deployments/{model}/chat/completions") | ||
| async def chat_proxy_deployment(provider: str, model: str, request: Request) -> Response: | ||
| """Proxy for chat completions to the specified provider with deployment path.""" | ||
| return await chat_proxy(provider, request) | ||
|
|
||
|
|
||
| @app.post("/provider/{provider}/{subpath:path}/chat/completions") |
There was a problem hiding this comment.
The wildcard path pattern could create ambiguous routing. This endpoint will match URLs that should be handled by more specific endpoints above it. Consider placing this route after all other specific patterns or adding additional constraints to prevent conflicts.
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.