Clean up jsonrpc message handling #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidies up the message handling quite a bit to reduce complexity and fix a couple of bugs. This also resolved an issue with error log messages not being parsed correctly, and handles multiple devices when debugging. Closes emacs-lsp#183
elken
force-pushed
the
fix/multiple-device-parsing
branch
from
136cd99 to
e242ba2
Compare
|
As per the commit message, this also highlighted the fact that error log messages weren't being parsed correctly at all. I don't get any errors now when trying to load the daemon up, load the list of devices through |
ericdallo
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidies up the message handling quite a bit to reduce complexity and fix
a couple of bugs.
This also resolved an issue with error log messages not being parsed
correctly, and handles multiple devices when debugging.
Closes #183