Skip to content

Remove emacs-snapshot #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove emacs-snapshot #180

wants to merge 1 commit into from

Conversation

elken
Copy link
Contributor

@elken elken commented Sep 10, 2022

Should make CI pass, there's an on-going bug RE: loaddefs

EDIT: it doesn't so remove it for now at least

@elken elken changed the title Mark emacs-snapshot experimental Remove emacs-snapshot Sep 10, 2022
Should make CI pass, there's an on-going bug RE: loaddefs
@jcs090218
Copy link
Member

I think the experimental flag would only make the badge green, but won't fix the CI itself.

@elken
Copy link
Contributor Author

elken commented Sep 10, 2022

I think the experimental flag would only make the badge green, but won't fix the CI itself.

It did not sadly

@ericdallo
Copy link
Member

Do we really need to remove snapshot if it's not a required check to merge PR?

If someday the snapshot is fixed builds will start to pass

@elken
Copy link
Contributor Author

elken commented Sep 10, 2022

It's not required, but you don't get the nice green tick :P I don't see much value in testing against the latest, brittle versions of emacs but it's your project; so this is fine to be closed 😄

@ericdallo
Copy link
Member

ericdallo commented Sep 10, 2022

It used to be green, if we remove it we won't know if they fix the issue on snapshot, but I'm fine with both ways
It's not my project, it's ours :)

@jcs090218
Copy link
Member

I would suggest just to ignore it for now. But I can live in both ways too. ;)

@elken
Copy link
Contributor Author

elken commented Sep 10, 2022

Agree with all points here, guess my Q/A OCD is seeping through :P

@elken elken closed this Sep 10, 2022
@elken elken deleted the patch-1 branch September 10, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants