Skip to content

Devtools improvements #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Devtools improvements #177

merged 2 commits into from
Sep 6, 2022

Conversation

elken
Copy link
Contributor

@elken elken commented Sep 6, 2022

lsp-dart-pub-command has recently changed to produce a list instead,
which breaks all the places it's expected in devtools.

Also add opt-in support for opening the devtools in an xwidgets frame

lsp-dart-pub-command has recently changed to produce a list instead,
which breaks all the places it's expected in devtools.
Allows the use of flutter devtools within an xwidgets frame
@elken elken changed the title Make devtools commands handle pub change Devtools improvements Sep 6, 2022
Copy link
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you!

@ericdallo ericdallo merged commit f02daae into emacs-lsp:master Sep 6, 2022
@elken elken deleted the fix/devtools branch September 6, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants