Fix: Replace Unsafe Java Deserialization with Jackson Mapper #770
+17
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses a critical security vulnerability in the code that could lead to Remote Code Execution (RCE). The code was using Java's built-in ObjectInputStream.readObject() for deserialization, which is known to be vulnerable to deserialization attacks if the input comes from an untrusted source. This vulnerability was initially found and fixed in the git commit below. References: apache/helix@7af17a3
|
sa-token-jboot-plugin 插件是由另一位用户开发提交的pr，如果将 jdk 序列化修改为 Jackson 序列化可能会违背该作者的原意，故不能合并此PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a critical security vulnerability in the code that could lead to Remote Code Execution (RCE).
The code was using Java's built-in ObjectInputStream.readObject() for deserialization, which is known to be vulnerable to deserialization attacks if the input comes from an untrusted source.
This vulnerability was initially found and fixed in the git commit below.
References:
https://github.com/apache/helix/commit/7af17a31819859e6c46bcb3994ef7d52347760c4