feat: extend bounding box #348
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rickymaggio02 <[email protected]>
Signed-off-by: rickymaggio02 <[email protected]>
Signed-off-by: rickymaggio02 <[email protected]>
…email.com> I, Riccardo Maggioni <[email protected]>, hereby add my Signed-off-by to this commit: 9e2d467 I, Riccardo Maggioni <[email protected]>, hereby add my Signed-off-by to this commit: 84917db Signed-off-by: Riccardo Maggioni <[email protected]>
|
❌ DCO Check Failed Hi @cau-git, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for Riccardo Maggioni <[email protected]>
I, Riccardo Maggioni <[email protected]>, hereby add my Signed-off-by to this commit: 9e2d4674a65274b3c2140007bcbc5d81518a7da2
I, Riccardo Maggioni <[email protected]>, hereby add my Signed-off-by to this commit: 84917dbc7c59eaf9cfcffa4f4dbe0d4c6db468e9
I, Christoph Auer <[email protected]>, hereby add my Signed-off-by to this commit: f514329ffe25f8c36a893a0beff847e5c42c3a5d"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
…ev/extend_bounding_box
PeterStaar-IBM
requested review from
PeterStaar-IBM,
vagenas and
dolfim-ibm
and removed request for
vagenas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for representing bounding boxes using 4-vertex convex polygons instead of axis-aligned rectangles. This allows for more accurate localization of elements within a document, especially in cases where the document is photographed under imperfect conditions, such as misalignment, bending, or stretching of the paper.
While the class name BoundingRectangle is currently used, it may be misleading and should potentially be renamed to better reflect the generalized shape (e.g., BoundingPolygon).
To support this new structure in SmolDocling, a dedicated localization token <rec_ has been added.
Significant effort has gone into ensuring backward compatibility within the Prov class and related methods, so existing workflows remain unaffected.