[WIP] Update test coverage for tools package #83
Closed
+234
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this - will re-open with additional coverage after the updated Go framework PR's are merged |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
CONTRIBUTING.mdupdated withTestingsection - which contains commands for quickly understanding current coverage.58.9%from36.0%(Note this is only for unit, integration coverage is higher)tools_test.gofor thetoolspackage. Switching to a model where we have separate test files for each like:call_test.goandenable_test.goRelated issue
toolsis:36.0% of statements. See screenshot below for file coverage breakdown:(not mandatory) A picture of a cute animal, if possible in relation to what you did
🐞