update container proxy behaviour with PAC file #22847
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karman-docker
requested review from
aevesdocker and
sarahsanders-docker
as code owners
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@Xeeynamo can you also take a look please and add/modify if needed ? Thank you. |
|
This should be merged after release of DD 4.42.1 |
aevesdocker
reviewed
Jun 20, 2025
| @@ -52,7 +52,7 @@ The `containersProxy` setting describes the policy which is applied to traffic f | |||
| > [!IMPORTANT] | |||
| > | |||
| > Any existing `proxy` setting in the `admin-settings.json` file continues to apply to traffic from the app on the host. | |||
| > If the PAC file download fails, the Docker Desktop app and its containers do not block the request; instead, they attempt to connect directly to the target URL. | |||
| > If the PAC file download fails, the containers block the request to the target URL. | |||
There was a problem hiding this comment.
Do we need to specify that this is only with version 4.42.1 and later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues or tickets
Relates to this code changes in https://github.com/docker/pinata/pull/34220 and https://github.com/docker/pinata/pull/34955. This PR updates the docs to reflect the new behaviour.
Reviews