-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add stac-auth-proxy construct #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
super(scope, id); | ||
|
||
this.lambdaFunction = new lambda.Function(this, "lambda", { | ||
runtime: lambda.Runtime.PYTHON_3_13, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level question for eoAPI-cdk ... could/should we use a common Python runtime for our lambdas (aka a package-level constant)?
Feels like that could be a slight maintenance burden reduction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's reasonable. It's hard for me to imagine a situation where upgrading Python would break a service. I'll go even a step further and suggest that it would be reasonable to have a common default but allow end-users to specify the environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original comment was brought to you by maintenance of https://earth-search.aws.element84.com/v1, which seemed to run into Lambda env deprecations all the time which always managed to be harder to unpick than we wanted. I figure having a single source of version helps us catch bitrot earlier and (hopefully) make the upgrades less painful.
# [9.2.0](v9.1.1...v9.2.0) (2025-07-22) ### Features * add stac-auth-proxy construct ([#171](#171)) ([f36ebaa](f36ebaa))
🎉 This PR is included in version 9.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
currently available at https://pypi.org/project/eoapi-cdk/9.2.0rc3/
closes #170