Skip to content

Issue #454: Vacuum dry run unavailable - deleted file information une… #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michelheil
Copy link

Hello, trying to solve issue #454 with the proposed changes. First time to contribute anywhere and especially to delta-io. Please feel free to provide any feedback on how to improve. Happy to amend accordingly.

Signed-off-by: Michael Heil [email protected]

@dennyglee
Copy link
Contributor

Sorry for the delays @michelheil - right now we're in the middle of refactoring for 1.0; once we get this up and running will review it. HTH!

@zsxwing
Copy link
Member

zsxwing commented Oct 7, 2021

Thanks for the contribution and sorry for the delay. Could you resolve the conflicts?

@zsxwing zsxwing added acknowledged This issue has been read and acknowledged by Delta admins enhancement New feature or request need author feedback Issue is waiting for the author to respond labels Oct 7, 2021
@michelheil
Copy link
Author

@zsxwing Unfortunately, I was not able to solve the failed binary compatibility check.

I am getting

[error]  * method executeVacuum(org.apache.spark.sql.delta.DeltaLog,scala.Option)org.apache.spark.sql.Dataset in class io.delta.tables.DeltaTable does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("io.delta.tables.DeltaTable.executeVacuum")
java.lang.RuntimeException: delta-core: Binary compatibility check failed!

but am unaware on how to deal with this.

@zsxwing
Copy link
Member

zsxwing commented Apr 22, 2022

Sorry for the delay. I missed your last comment. You can add an exclusion to https://github.com/delta-io/delta/blob/master/project/MimaExcludes.scala

@tdas
Copy link
Contributor

tdas commented May 3, 2022

Hey @michelheil any update on this PR? would be good to complete and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged This issue has been read and acknowledged by Delta admins enhancement New feature or request need author feedback Issue is waiting for the author to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants