Skip to content

Change collect method to LocalIterator for the SnapshotIterator #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change collect method to LocalIterator for the SnapshotIterator #588

wants to merge 2 commits into from

Conversation

fvaleye
Copy link
Contributor

@fvaleye fvaleye commented Feb 3, 2021

Related to #580

@fvaleye fvaleye force-pushed the change-collect-to-localiterator-in-snapshot-iterator branch from 922d7c6 to bc71ea5 Compare February 3, 2021 11:54
@GrigorievNick
Copy link
Contributor

Any news?
Do I need to fork 0.8.0 version, same as I do with 0.6.1?
Or there is a clear roadmap when this change will be in master?

@jaceklaskowski
Copy link
Contributor

@zsxwing Can you have a look?

@GrigorievNick
Copy link
Contributor

gentle ping.

@andresgomezfrr
Copy link

gentle ping.

@zsxwing
Copy link
Member

zsxwing commented Oct 7, 2021

Sorry for the delay. I realized one major issue of toLocalIterator is it would trigger a lot of Spark jobs (one partition one spark job, and lose parallelism) and make it much slower than collect. Have you seen performance issue in your usage?

@zsxwing zsxwing added the need author feedback Issue is waiting for the author to respond label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need author feedback Issue is waiting for the author to respond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fvaleye @GrigorievNick @jaceklaskowski @andresgomezfrr @zsxwing