[Protocol Change Request] Geospatial types #4726
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanl-db
reviewed
Jun 17, 2025
|
|
||
| For geospatial types, the most useful statistics for data skipping are **bounding boxes**. A bounding box is a minimal axis-aligned rectangle, parallelepiped, or hyper-parallelepiped, that fully contains all points of all geometries or geographies in a given set. It is typically represented by two points: the **lower-left** and **upper-right** corners. Each point must include **X** and **Y** coordinates, but may also optionally include **Z** (elevation) and **M** (measure) values. | ||
|
|
||
| Since a bounding box naturally defines spatial **minimum** and **maximum** values, we can leverage the existing min and max column statistics fields to store the points. The values are encoded in **[Well-Known Text (WKT)](https://libgeos.org/specifications/wkt/)** format. For example: |
There was a problem hiding this comment.
Suggested change
| Since a bounding box naturally defines spatial **minimum** and **maximum** values, we can leverage the existing min and max column statistics fields to store the points. The values are encoded in **[Well-Known Text (WKT)](https://libgeos.org/specifications/wkt/)** format. For example: | |
| Since a bounding box naturally defines spatial **minimum** and **maximum** values, these values are stored `minValues` and `maxValues fields of the `stats` field in `add` and `remove` actions. The values are encoded in **[Well-Known Text (WKT)](https://libgeos.org/specifications/wkt/)** format. For example: |
| Since a bounding box naturally defines spatial **minimum** and **maximum** values, we can leverage the existing min and max column statistics fields to store the points. The values are encoded in **[Well-Known Text (WKT)](https://libgeos.org/specifications/wkt/)** format. For example: | ||
|
|
||
| ```json | ||
| { |
There was a problem hiding this comment.
Can you also include the outer stats struct in the example?
|
|
||
| ### Per-file statistics | ||
|
|
||
| For geospatial types, the most useful statistics for data skipping are **bounding boxes**. A bounding box is a minimal axis-aligned rectangle, parallelepiped, or hyper-parallelepiped, that fully contains all points of all geometries or geographies in a given set. It is typically represented by two points: the **lower-left** and **upper-right** corners. Each point must include **X** and **Y** coordinates, but may also optionally include **Z** (elevation) and **M** (measure) values. |
There was a problem hiding this comment.
It is typically represented by two points: the lower-left and upper-right corners. Each point must include X and Y coordinates, but may also optionally include Z (elevation) and M (measure) values.
We need to be more precise here, this doesn't actually specify the format that must be used.
E.g.:
A bound box is represented by two points:
- the lower-left corner, defined as the minimum value
- the upper-right corner defined as the maximum value.
A point is represented by two floating values, encoded in Well-Known Text (WKT) format, e.g.:POINT(-122.419 37.774)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Adds the protocol changes for the Geospatial types (see #4725) to the RFC folder.
How was this patch tested?
N/A
Does this PR introduce any user-facing changes?
N/A