Skip to content

ensure that format specification in Metadata is respected #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekoifman
Copy link
Contributor

@ekoifman ekoifman commented Mar 5, 2020

ensure that Metadata.format.options is respected - closes #362

@databricks-cla-assistant

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ekoifman
Copy link
Contributor Author

@rahulsmahadev @tdas could someone take a look at this please?

@tdas
Copy link
Contributor

tdas commented Oct 7, 2021

@ekoifman Sorry for not responding to this back then. My thought on this change is that it is risky to transparently pass all options down into the parquet format. There are a few subtle assumptions that delta lake makes about parquet format (some details about how ints and longs are stored) which are intricately tied to delta... so it might be possible to break the compatibility of the delta table by making arbitrary changes to parquet by allowing arbitrary options. To safeguard against such corner case we are currently not allowing arbitrary options to be passed down.

However, that said, I totally buy that there are options that can super useful to pass down. We could built a allow-list of options to be passed down. If you are still interested in working on this, we can think in that direction. What do you think?

@tdas tdas added the enhancement New feature or request label Oct 7, 2021
@ekoifman
Copy link
Contributor Author

ekoifman commented Oct 8, 2021

@tdas Sure let me take a look. Do you have a list in mind?
Also, I'd expect the list to be hardcoded since no end user is expected to configure the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata.format.options is ignored
3 participants