Skip to content

fix: version binary search #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aditanase
Copy link
Contributor

@aditanase aditanase commented Jun 20, 2025

Description

Version search does not work if there are temporary parquet checkpoint files in the _delta_log folder.

The 2nd commit fixes a regression introduced in a recent commit that uses the kernel to look for max_version, which fails if the version doesn't start at 0 (rarely the case on an older table).

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jun 20, 2025
@aditanase aditanase changed the title fix: version binary search (exclude checkpoint.tmp) fix: version binary search Jun 20, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.22%. Comparing base (2cc8081) to head (cd61fc5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3549      +/-   ##
==========================================
- Coverage   74.23%   74.22%   -0.01%     
==========================================
  Files         150      150              
  Lines       44739    44742       +3     
  Branches    44739    44742       +3     
==========================================
- Hits        33213    33211       -2     
+ Misses       9384     9381       -3     
- Partials     2142     2150       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ion-elgreco
Copy link
Collaborator

A test would be nice

@aditanase
Copy link
Contributor Author

aditanase commented Jun 23, 2025

@ion-elgreco thanks! Added 1 tests to time_travel.rs, without it it crashes with:

called Result::unwrap() on an Err value: NotATable("../delta-rs/crates/test/tests/data/checkpoints_vacuumed/")

This is covering both changes I made, using the checkpoints_vacuumed test table

@aditanase
Copy link
Contributor Author

@ion-elgreco FYI this seems to be the root cause of the issue introduced by migrating to kernel v11 for these operations:
https://github.com/delta-io/delta-kernel-rs/blob/main/kernel/src/log_segment.rs#L181

It does not handled compacted tables yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants