-
Notifications
You must be signed in to change notification settings - Fork 499
fix: version binary search #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Adrian Tanase <[email protected]>
Signed-off-by: Adrian Tanase <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3549 +/- ##
==========================================
- Coverage 74.23% 74.22% -0.01%
==========================================
Files 150 150
Lines 44739 44742 +3
Branches 44739 44742 +3
==========================================
- Hits 33213 33211 -2
+ Misses 9384 9381 -3
- Partials 2142 2150 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
A test would be nice |
Signed-off-by: Adrian Tanase <[email protected]>
@ion-elgreco thanks! Added 1 tests to
This is covering both changes I made, using the |
@ion-elgreco FYI this seems to be the root cause of the issue introduced by migrating to kernel v11 for these operations: It does not handled compacted tables yet. |
Description
Version search does not work if there are temporary parquet checkpoint files in the
_delta_log
folder.The 2nd commit fixes a regression introduced in a recent commit that uses the kernel to look for max_version, which fails if the version doesn't start at 0 (rarely the case on an older table).